chore: update stdlib_smoke_test.jsonnet with with float closing test#855
Merged
johnbartholomew merged 1 commit intogoogle:masterfrom Mar 1, 2026
Merged
chore: update stdlib_smoke_test.jsonnet with with float closing test#855johnbartholomew merged 1 commit intogoogle:masterfrom
johnbartholomew merged 1 commit intogoogle:masterfrom
Conversation
Collaborator
johnbartholomew
left a comment
johnbartholomew
left a comment
There was a problem hiding this comment.
Thanks - this is a good improvement.
He-Pin
force-pushed
the
smoke
branch
2 times, most recently
from
208a24f to
abdf2e0
Compare
This was referenced Feb 28, 2026
Contributor
Author
|
@johnbartholomew I think it's now ready. |
stephenamar-db
pushed a commit
to databricks/sjsonnet
that referenced
this pull request
Mar 1, 2026
Collaborator
|
Looks good. Thanks for sending the fix for assertClose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help sjsonnet and jrsonnet